From: Timur Tabi <timur@freescale.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v3] ASoC CS4270 codec device driver
Date: Tue, 31 Jul 2007 11:41:44 -0500 [thread overview]
Message-ID: <46AF6648.5000803@freescale.com> (raw)
In-Reply-To: <s5hy7gwttzp.wl%tiwai@suse.de>
Takashi Iwai wrote:
> OK, now found another problem. The driver seems not built without
> CONFIG_I2C.
>
> In file included from sound/soc/codecs/cs4270.c:1:
> sound/soc/codecs/cs4270.c:694: error: ‘cs4270_set_dai_sysclk’ undeclared here (not in a function)
> sound/soc/codecs/cs4270.c:695: error: ‘cs4270_set_dai_fmt’ undeclared here (not in a function)
>
> Shouldn't the driver be dependent on I2C?
Well, technically no. It should work find without I2C, but I admit I never tried that.
I'll provide a fix soon.
> Also,
>
> #ifdef CONFIG_I2C
>
> isn't enough. It should be
>
> #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
I asked about that a while ago, and I never got an answer. Where does CONFIG_I2C_MODULE
come from? I don't see it in any Kconfig or any header file. And if I2C can be a module,
then why wouldn't CONFIG_I2C also be defined?
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2007-07-31 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 15:46 [PATCH v3] ASoC CS4270 codec device driver Timur Tabi
2007-07-31 16:00 ` Takashi Iwai
2007-07-31 16:12 ` Timur Tabi
2007-07-31 16:17 ` Takashi Iwai
2007-07-31 16:31 ` Takashi Iwai
2007-07-31 16:41 ` Timur Tabi [this message]
2007-07-31 18:34 ` Trent Piepho
2007-07-31 18:53 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AF6648.5000803@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.