From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933306AbXGaQwg (ORCPT ); Tue, 31 Jul 2007 12:52:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765195AbXGaQw0 (ORCPT ); Tue, 31 Jul 2007 12:52:26 -0400 Received: from gw.goop.org ([64.81.55.164]:40713 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763750AbXGaQwZ (ORCPT ); Tue, 31 Jul 2007 12:52:25 -0400 Message-ID: <46AF68C7.9030100@goop.org> Date: Tue, 31 Jul 2007 09:52:23 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.5 (X11/20070719) MIME-Version: 1.0 To: Neil Horman CC: akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] argv_split: allow argv_split to handle NULL pointer in argcp parameter gracefully References: <20070731164608.GB28333@hmsreliant.homelinux.net> In-Reply-To: <20070731164608.GB28333@hmsreliant.homelinux.net> X-Enigmail-Version: 0.95.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Neil Horman wrote: > As Jeremy and I had discussed in a previous thread, it would be nice if the > argv_split library function could gracefully handle a NULL pointer in the argcp > parameter, so as to allow functions using it that did not care about the value > of argc to not have to declare a useless variable. This patch accomplishes > that. Tested by me, with successful results. > > Looks good to me. J