All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Green <andy@warmcat.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: Jiri Benc <jbenc@suse.cz>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] zd1211rw-mac80211: debug output for mac80211 ops
Date: Tue, 31 Jul 2007 22:42:46 +0100	[thread overview]
Message-ID: <46AFACD6.9020607@warmcat.com> (raw)
In-Reply-To: <200707312330.48698.mb@bu3sch.de>

Somebody in the thread at some point said:
> On Tuesday 31 July 2007 23:12:49 Jiri Benc wrote:
>> On Tue, 31 Jul 2007 00:25:21 +0100, Andy Green wrote:
>>> The "soft" one is a faked up repeating of incoming (and outgoing!
>>> twice!) packets
>> You mean you see each outgoing packet twice on soft monitor interface? That
>> would be a bug.
>>
>>> It really would be much better if the device
>>> is kicked to hardware promisc if ANY virtual interface is in Monitor
>>> mode, therefore the results are consistent regardless of the number of
>>> virtual interfaces that happen to be around.
>> Of course. If the hardware supports that.
> 
> The device should _not_ be kicked to promisc, if we have a monitor
> interface. The promisc bit is a completely seperate setting
> and must be handled seperate from the monitor stuff.
> Userspace does take care of setting the promisc bit, if it's
> required.
> We recently fixed this bug in bcm43xx.

Well that's fine... tcpdump for example does IFF_PROMISC while it runs
so nobody who doesn't care will notice the difference, but I guess you
get the power saving while IFF_PROMISC is off and the Monitor mode
interface is up.

But anyone who tcpdumps on a Monitor mode interface still always sees
the whole picture, not the synthesized one.  Sounds like a good general
way to me.

-Andy

  reply	other threads:[~2007-07-31 21:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070730023128.99E927B409F@zog.reactivated.net>
2007-07-30  3:21 ` [PATCH] zd1211rw-mac80211: debug output for mac80211 ops Michael Wu
2007-07-30 14:51   ` John W. Linville
2007-07-30 22:52     ` Ulrich Kunitz
2007-07-30 23:05       ` Michael Buesch
2007-07-30 23:25         ` Andy Green
2007-07-31 21:12           ` Jiri Benc
2007-07-31 21:30             ` Michael Buesch
2007-07-31 21:42               ` Andy Green [this message]
2007-07-31 21:50             ` Andy Green
2007-07-31  5:22         ` Michael Wu
2007-07-31  9:39           ` Michael Buesch
2007-07-31 21:06           ` Jiri Benc
2007-07-31 21:39             ` Michael Buesch
2007-07-31  5:06       ` Michael Wu
2007-07-31 21:00       ` Jiri Benc
2007-07-31 21:37         ` Michael Buesch
2007-07-31 22:10           ` Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46AFACD6.9020607@warmcat.com \
    --to=andy@warmcat.com \
    --cc=jbenc@suse.cz \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.