All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org
Subject: Re: Early ATA devices
Date: Wed, 01 Aug 2007 09:47:49 -0400	[thread overview]
Message-ID: <46B08F05.9080306@garzik.org> (raw)
In-Reply-To: <20070801014137.4ab39e94@the-village.bc.nu>

Alan Cox wrote:
> #1	We assume identify works. Early ATA actually lists this command
> as optional

ITYM we assume identify command exists on the device?

We certainly do not assume IDENTIFY command, if exists, succeeds.

What is the proper probing method -- notice if command-aborted is 
returned and do something from there?


> #2	We don't allow for INIT_DEV_PARAMS failing which it may do on
> some early IDE pre ATA devices

Suggested handling?  Ignore device, since we don't know what state its 
in, if this fails?


> We check ATA < 4 || non-LBA capable when deciding whether to issue
> INIT_DEV_PARAMS. ATA 4+ however mandate LBA so the second case isn't
> theoretically at least possible.

I agree, though I figured that the current code was more robust, in case 
some weirdo device decided to forget its LBA-ness.

No strong opinions here, though.


> So in theory we can persuade libata to drive original MFM/RLL disks with
> relatively few changes

Crazy :)

	Jeff




  parent reply	other threads:[~2007-08-01 13:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01  0:41 Early ATA devices Alan Cox
2007-08-01  6:02 ` Tejun Heo
2007-08-02 20:47   ` Alan Cox
2007-08-15 17:19     ` Erik Mouw
2007-08-15 17:48       ` Alan Cox
2007-08-01 13:47 ` Jeff Garzik [this message]
2007-08-01 15:31   ` Alan Cox
2007-08-01 18:06   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B08F05.9080306@garzik.org \
    --to=jeff@garzik.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.