All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Michael Buesch <mb@bu3sch.de>, Michael Chan <mchan@broadcom.com>,
	davem@davemloft.net, netdev@vger.kernel.org,
	eliezert@broadcom.com, lusinsky@broadcom.com,
	eilong@broadcom.com
Subject: Re: [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet.
Date: Wed, 01 Aug 2007 18:50:49 -0400	[thread overview]
Message-ID: <46B10E49.1080904@garzik.org> (raw)
In-Reply-To: <adaodhq6gal.fsf@cisco.com>

Roland Dreier wrote:
>  > > +	{ PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_NX2_5710,
>  > > +		PCI_ANY_ID, PCI_ANY_ID, 0, 0, BCM5710 },
> 
> FWIW, this could be neater as
> 
> 	{ PCI_VDEVICE(BROADCOM, PCI_DEVICE_ID_NX2_5710), BCM5710 }

Yes.  And additionally, I prefer (but not require) that people directly 
use a hexidecimal constant in the PCI ID table for device ID, if that is 
the only place in the entire codebase referring to that PCI device ID.

Using a named constant for a single-use PCI device ID merely aggrevates 
include/linux/pci_ids.h patching headache for what is ultimately an 
arbitrary number [usually] picked out of thin air by the hw vendor.

	Jeff




  reply	other threads:[~2007-08-01 22:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01  8:31 [RFC][BNX2X]: New driver for Broadcom 10Gb Ethernet Michael Chan
2007-08-01 22:06 ` Michael Buesch
2007-08-01 22:28   ` Roland Dreier
2007-08-01 22:50     ` Jeff Garzik [this message]
2007-08-02 18:13       ` Eliezer Tamir
2007-08-02 18:09   ` Eliezer Tamir
2007-08-02 21:48   ` Michael Chan
2007-08-07 22:15   ` Jeff Garzik
2007-08-07 22:20     ` Michael Buesch
2007-08-07 23:04       ` Christoph Hellwig
2007-08-07 23:08         ` David Miller
2007-08-08  8:40           ` Michael Buesch
2007-08-07 23:04   ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B10E49.1080904@garzik.org \
    --to=jeff@garzik.org \
    --cc=davem@davemloft.net \
    --cc=eilong@broadcom.com \
    --cc=eliezert@broadcom.com \
    --cc=lusinsky@broadcom.com \
    --cc=mb@bu3sch.de \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.