All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <larry.finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Buesch <mb@bu3sch.de>,
	bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [RFC V2] bcm43xx-mac80211: Provide information to allow  transmission  rate decreases
Date: Thu, 02 Aug 2007 10:02:25 -0500	[thread overview]
Message-ID: <46B1F201.7060107@lwfinger.net> (raw)
In-Reply-To: <1186060034.24230.48.camel@johannes.berg>

Johannes Berg wrote:
> On Thu, 2007-08-02 at 15:03 +0200, Michael Buesch wrote:
> 
>> So, what's the point of this "excessive retries" field anyway?
>> We already have an "acked" bit. So if it's not set, but we expected an
>> ack, what's the point of setting excessive retries in the driver?
>> the rc algo sould know _anyway_, as it has the "acked" and the
>> "we wanted to have an ack" bits.
> 
> No idea. I guess you get to dig through the code and remove it ;)

When I first started investigating the problem of mac80211 not reducing the rate as I moved away 
from the AP, it seemed to me that the decision regarding excessive retries should be made in 
mac80211, not in the driver; however, I have had extreme difficulty in getting any changes into 
mac80211 on several occasions. Linville assures me that he has had private discussions about this 
problem; however, I needed a quick fix and couldn't stand any protracted discussion and/or review 
delays. I knew Michael would be tough, but that his comments would not be delayed.

At the moment, I have more pressing matters to resolve than fixing this problem in mac80211; 
however, I feel really good that the port of bcm43xx-softmac to mac80211 has this issue.

Larry


  reply	other threads:[~2007-08-02 15:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01 20:56 [RFC V2] bcm43xx-mac80211: Provide information to allow transmission rate decreases Larry Finger
2007-08-01 22:14 ` Michael Buesch
2007-08-02  9:09   ` Johannes Berg
2007-08-02 11:11     ` Michael Buesch
2007-08-02 11:18       ` Johannes Berg
2007-08-02 11:37         ` Michael Buesch
2007-08-02 11:48           ` Johannes Berg
2007-08-02 13:03             ` Michael Buesch
2007-08-02 13:07               ` Johannes Berg
2007-08-02 15:02                 ` Larry Finger [this message]
2007-08-03  9:40                   ` Johannes Berg
2007-08-01 22:48 ` rob m

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B1F201.7060107@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.