All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org, Natalie Protasevich <protasnb@gmail.com>
Subject: Re: net driver error accounting
Date: Thu, 02 Aug 2007 16:38:09 -0400	[thread overview]
Message-ID: <46B240B1.9080003@garzik.org> (raw)
In-Reply-To: <20070802131718.84543097.akpm@linux-foundation.org>

Andrew Morton wrote:
> Looking at http://bugzilla.kernel.org/show_bug.cgi?id=8106
> 
> Guys, could we please have a ruling here?
> 
> When a net driver encounters a tx_fifo_error, should this also contribute
> to the tx_error count, or should it not?

For each TX error, (a) tx_error is incremented and (b) a more-specific 
TX error stat is also potentially incremented.  So, yes, tx_error 
accumulates.

See cp_tx() in 8139cp.


> More generally, should netdev drivers accumulate all the detailed
> rx_errors into net_device_stats.rx_errors in real time, or should they not?

For each RX error, (a) rx_error is incremented and (b) a more-specific 
RX error stat is also potentially incremented.  So, yes, rx_error 
accumulates.

See cp_rx_err_acct() in 8139cp.

	Jeff



  reply	other threads:[~2007-08-02 20:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02 20:17 net driver error accounting Andrew Morton
2007-08-02 20:38 ` Jeff Garzik [this message]
2007-08-02 20:45   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B240B1.9080003@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=protasnb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.