All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ide: move ide_config_drive_speed() calls to upper layers
Date: Sun, 05 Aug 2007 16:58:37 +0400	[thread overview]
Message-ID: <46B5C97D.20004@ru.mvista.com> (raw)
In-Reply-To: <200708040101.34574.bzolnier@gmail.com>

Hello.

Bartlomiej Zolnierkiewicz wrote:

>>    I have a feeling that only pdc202xx_new and jmicron drivers actually need 
>>this flag (and the latter one actually doesn't care as its methods are empty 
>>anyway).  Well, AMD/VIA chips enable UltraDMA mode by snooping Set Features 
>>command (as the drivers tell them to do so), so the order seems important 
>>unless that is changed.

    I've mixed it up (again :-): setting the MSB of the UltraDMA registers 
should be disabling Set Features snooping, so still the flag doesn't seem 
needed...

> Since changing of order affects the way in which hardware is accessed
> I prefer to keep such changes out of this patch (which is just a cleanup).

    I understand.

> Could you please handle them in pre or post patch(es)?

    More likely in post-patches -- I'll probably be out-of-office for the next 
several weeks (only appearing at weekends).

> Bart

WBR, Sergei

  reply	other threads:[~2007-08-05 12:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-27  0:22 [PATCH] ide: move ide_config_drive_speed() calls to upper layers Bartlomiej Zolnierkiewicz
2007-07-27  0:29 ` Bartlomiej Zolnierkiewicz
2007-07-27  0:31   ` Bartlomiej Zolnierkiewicz
2007-07-27 11:27 ` Alan Cox
2007-07-27 19:19   ` Bartlomiej Zolnierkiewicz
2007-07-28 18:57     ` Sergei Shtylyov
2007-08-03 23:01       ` Bartlomiej Zolnierkiewicz
2007-08-05 12:58         ` Sergei Shtylyov [this message]
2007-07-29 12:28 ` Sergei Shtylyov
2007-08-03 23:01   ` Bartlomiej Zolnierkiewicz
2007-08-06 17:43     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B5C97D.20004@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.