From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/11] atiixp: DMA setup fixes
Date: Mon, 06 Aug 2007 18:58:17 +0400 [thread overview]
Message-ID: <46B73709.8080509@ru.mvista.com> (raw)
In-Reply-To: <200708042205.37590.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> * Fix handling of unsupported/invalid modes in atiixp_set_dma_mode().
> * ATI controllers allow separate PIO and DMA timings so remove programming
> of PIO modes from atiixp_set_dma_mode(). Also remove no longer needed
> atiixp_dma_2_pio() helper.
Why they copied it over from the piix.c in the firs place?! Oh, the human
laziness (an cluelessness too)! :-(
> * SWDMA timings are not programmed by atiixp_set_dma_mode() and if SWDMA
> mode is chosen atiixp_dma_host_on() erroneously enables UDMA, just disable
> support for SWDMA modes for now.
> * Enable support for MWDMA0 mode.
> * Bump driver version.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-08-06 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-04 20:05 [PATCH 1/11] atiixp: DMA setup fixes Bartlomiej Zolnierkiewicz
2007-08-06 14:58 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B73709.8080509@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.