Re: [RFC] bcm43xx-mac80211: Add TX power set file to debugfs

[Larry Finger <larry.finger@lwfinger.net>]

Michael Buesch wrote:
> On Monday 06 August 2007 22:22:14 Larry Finger wrote:
>> Index: wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_main.c
>> ===================================================================
>> --- wireless-dev.orig/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_main.c
>> +++ wireless-dev/drivers/net/wireless/bcm43xx-mac80211/bcm43xx_main.c
>> @@ -2762,12 +2762,11 @@ static int bcm43xx_dev_config(struct iee
>>  	}
>>  
>>  	/* Adjust the desired TX power level. */
>> -	if (conf->power_level != 0) {
>> -		if (conf->power_level != phy->power_level) {
>> -			phy->power_level = conf->power_level;
>> -			bcm43xx_phy_xmitpower(dev);
>> -		}
>> -	}
>> +	if (conf->power_level != 0 && phy->power_level == 0) {
>> +		phy->power_level = conf->power_level;
>> +	} else
>> +		phy->power_level = 10;
>> +	bcm43xx_phy_xmitpower(dev);
> 
> No, what's that? I disagree with that.
> This breaks power adjustment.
> 

I just discovered that it fails. When I find the problem, I'll resubmit. Is the debugfs part right?

Larry