All of lore.kernel.org
 help / color / mirror / Atom feed
From: Varun Chandramohan <varunc@linux.vnet.ibm.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
	Oliver Hartkopp <socketcan@hartkopp.net>,
	Stephen Hemminger <shemminger@linux-foundation.org>
Subject: Re: [PATCH 3/4 -rev1] Initilize and populate age field
Date: Tue, 07 Aug 2007 10:22:15 +0530	[thread overview]
Message-ID: <46B7FA7F.1030700@linux.vnet.ibm.com> (raw)

Hi Eric,

                Sorry for the late response. I just need few
clarifications.              

               *age = timeval_to_sec(&tv);

         >>>> +        NLA_PUT_U32(skb, RTA_AGE, *age);

         >>> here, what happens if sizeof(time_t) is not 4 ?

              Did you mean that the above should be like this?
               NLA_PUT_U32(skb, RTA_AGE, (unsigned int) *age);

     return tv->tv_sec + (tv->tv_usec ? 1 : 0);

     is much faster

         So can we say that "usec" is *always *< 1000000 ?
            

Regards,
Varun

             reply	other threads:[~2007-08-07  4:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-07  4:52 Varun Chandramohan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-07-26  5:15 [PATCH 3/4 -rev1] Initilize and populate age field Varun Chandramohan
2007-07-26  6:03 ` Eric Dumazet
2007-07-26  6:27   ` Varun Chandramohan
2007-07-26  6:37     ` Eric Dumazet
2007-07-26  6:59       ` Varun Chandramohan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B7FA7F.1030700@linux.vnet.ibm.com \
    --to=varunc@linux.vnet.ibm.com \
    --cc=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.