From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.dvmed.net (srv5.dvmed.net [207.36.208.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 02620DDDE4 for ; Wed, 8 Aug 2007 07:50:05 +1000 (EST) Message-ID: <46B8E908.8010701@garzik.org> Date: Tue, 07 Aug 2007 17:50:00 -0400 From: Jeff Garzik MIME-Version: 1.0 To: Brian King Subject: Re: [PATCH 3/6] ibmveth: Add ethtool TSO handlers References: <11864293333377-patch-mail.ibm.com> <200708061942.l76JgSnp016148@d03av04.boulder.ibm.com> In-Reply-To: <200708061942.l76JgSnp016148@d03av04.boulder.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@ozlabs.org, rcjenn@linux.vnet.ibm.com, santil@linux.vnet.ibm.com, netdev@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Brian King wrote: > Add handlers for get_tso and get_ufo to prevent errors being printed > by ethtool. > > Signed-off-by: Brian King > --- > > drivers/net/ibmveth.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso drivers/net/ibmveth.c > --- linux-2.6/drivers/net/ibmveth.c~ibmveth_ethtool_get_tso 2007-07-19 11:18:38.000000000 -0500 > +++ linux-2.6-bjking1/drivers/net/ibmveth.c 2007-07-19 11:18:38.000000000 -0500 > @@ -759,7 +759,9 @@ static const struct ethtool_ops netdev_e > .get_tx_csum = ethtool_op_get_tx_csum, > .set_tx_csum = ibmveth_set_tx_csum, > .get_rx_csum = ibmveth_get_rx_csum, > - .set_rx_csum = ibmveth_set_rx_csum > + .set_rx_csum = ibmveth_set_rx_csum, > + .get_tso = ethtool_op_get_tso, > + .get_ufo = ethtool_op_get_ufo ACK, once you add a comma to the end of the final initializer As you see from this patch, the practice of -not- having commas at the end of a list of struct initializers is not patch-friendly, since you must touch an unrelated line each time you patch the end of the struct. For named initializers particularly, the lack of a comma is even more useless. So, it might tweak some C perfectionists, but adding that seemingly-useless comma at the end of the last entry reduces maintenance headache and makes patch reviews slightly more clear. Jeff