From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [NETFILTER 00/03]: Netfilter fixes
Date: Wed, 08 Aug 2007 15:58:14 +0200 [thread overview]
Message-ID: <46B9CBF6.1050209@trash.net> (raw)
In-Reply-To: <20070807.181242.89281020.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Mon, 6 Aug 2007 15:29:03 +0200 (MEST)
>
>
>> these patches fix a few netfilter bugs: failure to load IPv4 connection tracking
>> when loading the NAT module, an invalid return code in ctnetlink and a possible
>> NULL pointer dereference in ipt_recent. I'll pass the NULL pointer fix to
>> -stable once its upstream.
>>
>> Please apply, thanks.
>>
>
> Applied, thanks Patrick.
>
> I really wish those dependencies could be worked out in a nicer
> way than calling NULL functions in the needed module.
>
Its not very pretty, I agree. In this case we could have used
indirect dependencies and request_module, but I actually prefer
the symbol dependency because its visible in lsmod, which makes
it easier to figure out what needs to be unloaded first to
remove a module.
next prev parent reply other threads:[~2007-08-08 13:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 13:29 [NETFILTER 00/03]: Netfilter fixes Patrick McHardy
2007-08-06 13:29 ` [NETFILTER 01/03]: ipt_recent: avoid a possible NULL pointer deref in recent_seq_open() Patrick McHardy
2007-08-06 13:29 ` [NETFILTER 02/03]: ctnetlink: return EEXIST instead of EINVAL for existing nat'ed conntracks Patrick McHardy
2007-08-06 13:29 ` [NETFILTER 03/03]: nf_nat: add symbolic dependency on IPv4 conntrack Patrick McHardy
2007-08-08 1:12 ` [NETFILTER 00/03]: Netfilter fixes David Miller
2007-08-08 13:58 ` Patrick McHardy [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-28 22:06 Patrick McHardy
2008-04-29 10:16 ` David Miller
2007-11-29 23:57 Patrick McHardy
2007-11-30 13:04 ` Herbert Xu
2007-11-13 10:55 Patrick McHardy
2007-06-05 13:35 Patrick McHardy
2007-03-06 7:44 Patrick McHardy
2007-03-07 4:25 ` David Miller
2007-01-30 18:16 Patrick McHardy
2007-01-30 22:25 ` David Miller
2007-01-25 0:21 Patrick McHardy
2007-01-26 9:08 ` David Miller
2007-01-26 14:50 ` Jorge Bastos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B9CBF6.1050209@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.