Re: [PATCH] drop unneeded variable in amd_apic_timer_broken

[Tim Gardner <tim.gardner@canonical.com>]

Cal Peake wrote:
> On Wed, 8 Aug 2007, Andi Kleen wrote:
> 
>> Can you please test if this patch works?
> 
> Yep, seems to do the trick. Thanks!
> 
>> BTW I checked with AMD and they seem to think it's just a buggy BIOS.
> 
> Nod. Atleast we can work around it.
> 
>> Use global flag to disable broken local apic timer on AMD CPUs.
>>
>> The Averatec 2370 laptop BIOS seems to program the ENABLE_C1E
> 
> s~2370~2370/2371~ to be completely accurate ;)
> 
>> MSR inconsistently between cores. This confuses the lapic
>> use heuristics wants to know if C1E is enabled anywhere.
>>
>> Use a global flag instead of a per cpu flag to handle this.
>> If any CPU has C1E enabled disabled lapic use.
>>
>> Thanks to Cal Peake for debugging.
>> Signed-off-by: Andi Kleen <ak@suse.de>
> 
> Acked-by: Cal Peake <cp@absolutedigital.net>
> 

This patch also solves the boot problem on a Dell E1501. I started the
thread "ACPI Regression on Dell E1501" regarding this issue on June 21,
2007.

Acked-by: Tim Gardner <tim.gardner@ubuntu.com>

-- 
Tim Gardner tim.gardner@ubuntu.com