From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Guthro <bguthro@virtualiron.com>
Subject: Re: fully virtualized vista
Date: Wed, 08 Aug 2007 15:15:48 -0400
Message-ID: <46BA1664.7000600@virtualiron.com>
References: <46B9C28E.E57C.0030.0@novell.com>
	<46BA0E9B.6020305@virtualiron.com>
	<46B9CCD4.E57C.0030.0@novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------050900070106000301030007"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <46B9CCD4.E57C.0030.0@novell.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ky Srinivasan <ksrinivasan@novell.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.

--------------050900070106000301030007
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Patch is attached. Hope this helps


Ky Srinivasan wrote:
> Thanks Ben. I would be interested in the patch.
>
> K. Y
>
>   
>>>> On Wed, Aug 8, 2007 at  2:42 PM, in message <46BA0E9B.6020305@virtualiron.com>,
>>>>         
> Ben Guthro <bguthro@virtualiron.com> wrote: 
>   
>> There is a CRC bug in the RTL8139 implementation in the QEMU used in 3.1
>> There have been discussions of this on the QEMU list, as well.
>>
>> We have a patch for 3.1, but have not ported it forward to unstable yet, 
>> since unstable is using a newer version of QEMU.
>>
>> If there is interest in seeing the 3.1 patch, I'd be happy to post it.
>>
>>
>>
>> Ky Srinivasan wrote:
>>     
>>> I am having networking issues on fully virtualized Vista. Is this a known 
>>>       
>> issue.
>>     
>>> K. Y
>>>
>>>
>>>
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@lists.xensource.com
>>> http://lists.xensource.com/xen-devel
>>>   
>>>       
>
>
>   


--------------050900070106000301030007
Content-Type: text/x-patch;
 name="qemu-rtl8139-crc.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="qemu-rtl8139-crc.patch"

diff -r 05858d742ba7 tools/ioemu/hw/rtl8139.c
--- a/tools/ioemu/hw/rtl8139.c	Wed Jul 18 10:46:24 2007 -0400
+++ b/tools/ioemu/hw/rtl8139.c	Wed Jul 18 10:46:30 2007 -0400
@@ -55,7 +55,7 @@
 
 /* RTL8139 provides frame CRC with received packet, this feature seems to be
    ignored by most drivers, disabled by default */
-//#define RTL8139_CALCULATE_RXCRC 1
+#define RTL8139_CALCULATE_RXCRC 1
 
 /* Uncomment to enable on-board timer interrupts */
 //#define RTL8139_ONBOARD_TIMER 1
@@ -1032,7 +1032,7 @@ static void rtl8139_do_receive(void *opa
 
         /* write checksum */
 #if defined (RTL8139_CALCULATE_RXCRC)
-        val = cpu_to_le32(crc32(~0, buf, size));
+        val = cpu_to_le32(crc32(0, buf, size));
 #else
         val = 0;
 #endif
@@ -1138,7 +1138,7 @@ static void rtl8139_do_receive(void *opa
 
         /* write checksum */
 #if defined (RTL8139_CALCULATE_RXCRC)
-        val = cpu_to_le32(crc32(~0, buf, size));
+        val = cpu_to_le32(crc32(0, buf, size));
 #else
         val = 0;
 #endif

--------------050900070106000301030007
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------050900070106000301030007--