Re: [PATCH 1/1] NFS: change the ip_map cache code to handle IPv6 addresses

[Chuck Lever <chuck.lever@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

Aurélien Charbon wrote:
>>> @@ -112,12 +112,16 @@
>>>      return (hash ^ (hash>>8)) & 0xff;
>>>  }
>>>  #endif
>>> +static inline int hash_ip6(struct in6_addr ip)
>>> +{
>>> +        return (hash_ip(ip.s6_addr32[0]) ^ hash_ip(ip.s6_addr32[1]) 
>>> ^ hash_ip(ip.s6_addr32[2]) ^ hash_ip(ip.s6_addr32[3])) ;
>>> +}
>>
>>
>> How have you tested the effectiveness of the new hash function?
> 
> I have not tested that point but I can easily imagine there are better 
> solutions.
> Perhaps we can keep the same function for an IPv4 address (only taking 
> the 32 bits of IPv4 addr), and then design one for IPv6 addresses.

I see that, to generate the hash, you would be xor-ing the FF and 00 
bytes in the canonicalized IPv4 address.  Yes, perhaps a better function 
is needed, or as you say, one specifically for IPv6 and one for 
canonicalized IPv4.

> Do you have any suggestion on that ?

I don't have anything specific, but you may find something useful if you 
poke around elsewhere under net/.

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 302 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel
version:2.1
end:vcard