From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH] SCSI: Get SG_ALL out of the way Date: Thu, 09 Aug 2007 20:21:06 +0300 Message-ID: <46BB4D02.5050705@panasas.com> References: <46BB4A51.2080104@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from gw-colo-pa.panasas.com ([66.238.117.130]:20186 "EHLO cassoulet.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S936261AbXHIRV6 (ORCPT ); Thu, 9 Aug 2007 13:21:58 -0400 In-Reply-To: <46BB4A51.2080104@panasas.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Jens Axboe , James Bottomley , FUJITA Tomonori Cc: linux-scsi Boaz Harrosh wrote: > Jens hi playing with sglist and iscsi I stumbled on this. > You might want to add it to the sglist tree. Or maybe > James wants to include it for next merge window. > > =============================================================== > > - Some 50 scsi drivers use SG_ALL for their .sg_tablesize > So a value of 255 is a bit specific. Change it to ~0 > as meaning MAX_ what ever unsigned type it will ever be. > > Signed-off-by: Boaz Harrosh > --- > include/scsi/scsi_host.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h > index 88f6871..b84a4eb 100644 > --- a/include/scsi/scsi_host.h > +++ b/include/scsi/scsi_host.h > @@ -30,7 +30,7 @@ struct blk_queue_tags; > * used in one scatter-gather request. > */ > #define SG_NONE 0 > -#define SG_ALL 0xff > +#define SG_ALL (~0) > > > #define DISABLE_CLUSTERING 0 Sorry about that patch. I just did a make allmodconfig and it appears that some drivers use this constant as an Array size. I will submit a new Patch. Boaz