All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
To: lvm-devel@redhat.com
Subject: [LVM2 PATCH] Add lv_is_internal() to check internal LVs
Date: Thu, 09 Aug 2007 13:55:50 -0400	[thread overview]
Message-ID: <46BB5526.5030706@ce.jp.nec.com> (raw)

Internal LVs ("snapshotX", mirror logs and mimages) should
not be directly manipulated from commands.

Currently, it's allowed in some places, though.
# lvs -a
  LV               VG     Attr   LSize Origin Snap%  Move Log        Copy% 
  lvol0            testvg -wi-a- 4.00M                                     
  lvol2            testvg mwi-a- 4.00M                    lvol2_mlog 100.00
  [lvol2_mimage_0] testvg iwi-ao 4.00M                                     
  [lvol2_mimage_1] testvg iwi-ao 4.00M                                     
  [lvol2_mlog]     testvg lwi-ao 4.00M          
# lvresize -l+1 testvg/lvol2_mimage_1
  Extending logical volume lvol2_mimage_1 to 8.00 MB
# lvconvert -s testvg/lvol2_mimage_1 testvg/lvol0
  Logical volume lvol0 converted to snapshot.
# lvrename testvg/snapshot0 testvg/s
  Renamed "snapshot0" to "s" in volume group "testvg"
# lvconvert -m1 testvg/s
  Logical volume s converted.

Until the stacking of LVs are properly supported,
it's safer to disable them.

Attached patch adds lv_is_internal() to check internal LVs.
lv_is_visible() returns true for "snapshotX" so it can't
directly usable for this purpose.

Thanks,
-- 
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvm2-add-lv_is_internal.patch
Type: text/x-patch
Size: 3164 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20070809/eebfd8c3/attachment.bin>

             reply	other threads:[~2007-08-09 17:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-09 17:55 Jun'ichi Nomura [this message]
2007-08-09 18:23 ` [LVM2 PATCH] Add lv_is_internal() to check internal LVs Jun'ichi Nomura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46BB5526.5030706@ce.jp.nec.com \
    --to=j-nomura@ce.jp.nec.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.