From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: [PATCH] Fix xm block/network-detach command (take2) Date: Fri, 10 Aug 2007 16:08:23 -0600 Message-ID: <46BCE1D7.7050606@novell.com> References: <46BB61A3.7010903@novell.com> 29C7DB2CBD08C6kanno.masaki@jp.fujitsu.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <46BB61A3.7010903@novell.com> 29C7DB2CBD08C6kanno.masaki@jp.fujitsu.com List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Masaki Kanno Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Masaki Kanno wrote: > Hi Jim, > > Thanks for your tests. > > >> I tested your patch briefly on c/s 15672. >> > > >> The device was unplugged but its config not removed. From xend.log: >> >> File "/usr/lib64/python2.4/xen/xend/XendDomainInfo.py", line 615, in >> destroyDevice >> self.info['%s_refs' % deviceClass].remove(dev_uuid) >> KeyError: 'tap_refs' >> >> I think refs for the various disk types all fall under 'vbd_refs'. >> > > I tested blktap with the same way as your operation. But I did not > encounter the command error as follows. > But your thinking is right, so I wrote a small patch to remove the > error message. Could you test the patch again? > Looks good with your additional patch. Thanks. >> The behavior is fine (i.e. the disk is still attached and remains in >> stored config) but the error message is misleading. xvbd is connected, >> its just the front-end won't let go AFAIK. >> > > I'd like to improve the error message. Could you give me thinking > time about 2 weeks? > Sure. I just noticed it while testing but spent no time investigating. Regards, Jim