From: Chris Snook <csnook@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Andreas Schwab <schwab@suse.de>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
netdev@vger.kernel.org, akpm@linux-foundation.org, ak@suse.de,
heiko.carstens@de.ibm.com, davem@davemloft.net,
schwidefsky@de.ibm.com, wensong@linux-vs.org, horms@verge.net.au,
wjiang@resilience.com, cfriesen@nortel.com, zlynx@acm.org,
rpjday@mindspring.com, jesper.juhl@gmail.com
Subject: Re: [PATCH 9/24] make atomic_read() behave consistently on ia64
Date: Fri, 10 Aug 2007 19:15:42 -0400 [thread overview]
Message-ID: <46BCF19E.5000702@redhat.com> (raw)
In-Reply-To: <alpine.LFD.0.999.0708101607130.30176@woody.linux-foundation.org>
Linus Torvalds wrote:
>
> On Fri, 10 Aug 2007, Luck, Tony wrote:
>> Here are the functions in which they occur in the object file. You
>> may have to chase down some inlining to find the function that
>> actually uses atomic_*().
>
> Could you just make the "atomic_read()" and "atomic_set()" functions be
> inline functions instead?
>
> That way you get nice compiler warnings when you pass the wrong kind of
> object around. So
>
> static void atomic_set(atomic_t *p, int value)
> {
> *(volatile int *)&p->value = value;
> }
>
> static int atomic_read(atomic_t *p)
> {
> return *(volatile int *)&p->value;
> }
>
> etc...
I'll do this for the whole patchset. Stay tuned for the resubmit.
-- Chris
next prev parent reply other threads:[~2007-08-10 23:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-09 13:51 [PATCH 9/24] make atomic_read() behave consistently on ia64 Chris Snook
2007-08-09 21:03 ` Luck, Tony
2007-08-09 21:03 ` Luck, Tony
2007-08-10 19:51 ` Chris Snook
2007-08-10 21:19 ` Luck, Tony
2007-08-10 21:19 ` Luck, Tony
2007-08-10 21:42 ` Andreas Schwab
2007-08-10 21:42 ` Andreas Schwab
2007-08-10 22:33 ` Luck, Tony
2007-08-10 22:33 ` Luck, Tony
2007-08-10 22:43 ` Chris Snook
2007-08-10 22:59 ` Luck, Tony
2007-08-10 22:59 ` Luck, Tony
2007-08-10 23:09 ` Linus Torvalds
2007-08-10 23:15 ` Chris Snook [this message]
2007-08-11 0:35 ` Paul Mackerras
2007-08-13 6:30 ` Chris Snook
2007-08-13 7:39 ` Geert Uytterhoeven
2007-08-10 23:32 ` Luck, Tony
2007-08-10 23:32 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BCF19E.5000702@redhat.com \
--to=csnook@redhat.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=cfriesen@nortel.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=horms@verge.net.au \
--cc=jesper.juhl@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rpjday@mindspring.com \
--cc=schwab@suse.de \
--cc=schwidefsky@de.ibm.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=wensong@linux-vs.org \
--cc=wjiang@resilience.com \
--cc=zlynx@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.