From: Mark Levedahl <mdl123@verizon.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] builtin-bundle create - use lock_file
Date: Sun, 12 Aug 2007 14:22:55 -0400 [thread overview]
Message-ID: <46BF4FFF.1090309@verizon.net> (raw)
In-Reply-To: <7v1we8k5qx.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> When you exit before committing lockfiles
> you hold, atexit handler rolls back and unlink them for you.
>
> The following might be a better replacement.
>
> By the way, by using lockfile's "create temporary, generate into
> it and then rename to final", we are allowing an overwrite of an
> existing bundle, which we did not allow earlier. Is this check
> something we would want to preserve?
>
Ack - yours is much better. Thanks for the lesson. Also, the former
behavior of not allowing overwrite of an existing file was (at least in
my opinion) very un-git'ish so I am happy to see that go.
Mark
prev parent reply other threads:[~2007-08-12 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-12 12:53 [PATCH] builtin-bundle create - use lock_file semantics Mark Levedahl
2007-08-12 14:14 ` [PATCH] builtin-bundle create - use lock_file Mark Levedahl
2007-08-12 17:44 ` Junio C Hamano
2007-08-12 18:22 ` Mark Levedahl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BF4FFF.1090309@verizon.net \
--to=mdl123@verizon.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.