From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IKITI-0003lT-Sk for mharc-grub-devel@gnu.org; Sun, 12 Aug 2007 14:47:28 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IKITG-0003hl-Js for grub-devel@gnu.org; Sun, 12 Aug 2007 14:47:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IKITF-0003gP-F8 for grub-devel@gnu.org; Sun, 12 Aug 2007 14:47:26 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IKITF-0003gK-6c for grub-devel@gnu.org; Sun, 12 Aug 2007 14:47:25 -0400 Received: from py-out-1112.google.com ([64.233.166.177]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IKITF-0005WT-8E for grub-devel@gnu.org; Sun, 12 Aug 2007 14:47:25 -0400 Received: by py-out-1112.google.com with SMTP id f31so2385652pyh for ; Sun, 12 Aug 2007 11:47:23 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding; b=qZ9nBEZPNaTqXd2nkK3bd5G8dYxcJeS3rsa3z3mDEstvL5qXZOHJ+SJfq1yapID2KTy6l84L/M8hwg2EykPQQQJxPY95B+5jHiY84QjEf7WvITT8MZR91ZB2yVq9ZBz7PCg1gGlyUmnX+y45xJOhqQbmGI7MDo8Jl7GT0DfhBso= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding; b=NIHxhAT691StisjlJIV5JQKcHD20vPX5IsyUzR1nwezO3Ju/y0DhSeTtfswp2hDMB06SvGDxLZmQG1kBfCfKe3bvUMCZnyCsPDT7wcVh6LZt9n5IqlG/rupBUP1DCL7dJdWQSFvNL42XPZuaar5h/VPw/XmVHcOcmnlKQbllPtI= Received: by 10.65.154.2 with SMTP id g2mr8073442qbo.1186944442413; Sun, 12 Aug 2007 11:47:22 -0700 (PDT) Received: from ?10.0.0.6? ( [64.81.67.54]) by mx.google.com with ESMTPS id c6sm2422498qbc.2007.08.12.11.47.20 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 12 Aug 2007 11:47:21 -0700 (PDT) Message-ID: <46BF55BC.4020103@gmail.com> Date: Sun, 12 Aug 2007 11:47:24 -0700 From: Mischa Spiegelmock User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: The development of GRUB 2 References: <46BD54CF.2050800@gmail.com> <20070812144528.GC2260@aragorn> In-Reply-To: <20070812144528.GC2260@aragorn> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Detected-Kernel: Linux 2.6 (newer, 2) Subject: Re: Patch for boot message X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Aug 2007 18:47:27 -0000 Robert Millan wrote: > On Fri, Aug 10, 2007 at 11:18:55PM -0700, Mischa Spiegelmock wrote: > >> I got sick of grub saying "The highlighted entry will be booted >> automatically in 1 seconds." >> >> Here's a patch: >> >> Index: normal/menu.c >> =================================================================== >> RCS file: /sources/grub/grub2/normal/menu.c,v >> retrieving revision 1.18 >> diff -r1.18 menu.c >> 331,332c331,332 >> < The highlighted entry will be booted automatically in %d seconds. ", >> < timeout); >> --- >> >>> The highlighted entry will be booted automatically in %d >>> >> second%c ", >> >>> timeout, (timeout == 1 ? ' ' : 's')); >>> > > This breaks l10n, and also adds a bogus ' ' (although that's a minor issue). > > The SI symbol for second is 's'. Why not using that instead? > > Well whatever, I was just trying to fix the currently broken behavior. As for adding the "bogus" ' ', that's keeping in line with the comment on the line before: /* NOTE: Do not remove the trailing space characters. They are required to clear the line. */ I just tried to do the least invasive patch that would keep the amount of characters constant.