All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: nitin.a.kamble-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: kvm-devel
	<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"Yu,
	 Wilfred" <wilfred.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [Patch] (big) real mode emulation - jmp rel
Date: Mon, 13 Aug 2007 11:49:18 +0300	[thread overview]
Message-ID: <46C01B0E.7080304@qumranet.com> (raw)
In-Reply-To: <1186785157.6097.19.camel-mpPvwfgnXtFHIUuj5cj4Omt3HXsI98Cx0E9HWUfgJXw@public.gmane.org>

Nitin A Kamble wrote:
> Hi Avi,
>     The patch to implement "jmp rel" emulation is attached.

>  
> +#define jmp_rel(rel)							\
> +do {									\
> +	_eip += (int)(rel);						\
> +	_eip = ((op_bytes == 2) ? (uint16_t)_eip : (uint32_t)_eip);	\
> +} while (0)
> +

Please use an inline function instead of a macro.  That will help when 
we later make large scale changes (for example, splitting the emulator 
into a decoder and executor).

(and, when defining the macro, indent the contents)

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

  parent reply	other threads:[~2007-08-13  8:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10 22:32 [Patch] (big) real mode emulation - jmp rel Nitin A Kamble
     [not found] ` <1186785157.6097.19.camel-mpPvwfgnXtFHIUuj5cj4Omt3HXsI98Cx0E9HWUfgJXw@public.gmane.org>
2007-08-13  8:49   ` Avi Kivity [this message]
     [not found]     ` <46C01B0E.7080304-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-16  1:15       ` Nitin A Kamble
     [not found]         ` <1187226935.24576.5.camel-mpPvwfgnXtFHIUuj5cj4Omt3HXsI98Cx0E9HWUfgJXw@public.gmane.org>
2007-08-16 10:25           ` Avi Kivity
     [not found]             ` <46C42610.8020707-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-16 20:34               ` Nitin A Kamble
     [not found]                 ` <1187296469.5500.7.camel-mpPvwfgnXtFHIUuj5cj4Omt3HXsI98Cx0E9HWUfgJXw@public.gmane.org>
2007-08-16 23:54                   ` Nitin A Kamble
2007-08-17 12:24                   ` Avi Kivity
     [not found]                     ` <46C59385.6060108-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-17 22:24                       ` Nitin A Kamble
     [not found]                         ` <1187389499.9011.14.camel-mpPvwfgnXtFHIUuj5cj4Omt3HXsI98Cx0E9HWUfgJXw@public.gmane.org>
2007-08-19  8:03                           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C01B0E.7080304@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=nitin.a.kamble-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=wilfred.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.