All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Markus Rechberger" <markus.rechberger@amd.com>
To: linux-kernel@vger.kernel.org, "Jean Delvare" <khali@linux-fr.org>,
	"Greg KH" <greg@kroah.com>
Subject: [PATCH] Firmware class name collision
Date: Mon, 13 Aug 2007 15:11:50 +0200	[thread overview]
Message-ID: <46C05896.4050509@amd.com> (raw)

Hi,

following patch fixes the i2c name collision with i2c-dev.

http://mcentral.de/wiki/index.php/Bugtracker#i2c_core_problem

This issue has been experienced with em28xx and saa7133 based devices.
I discussed that problem with Jean Delvare a while ago and he proposed 
to add a prefix to the class name.

http://mcentral.de/~mrec/patches/firmware_class_name_collision.diff

Signed-off-by: Markus Rechberger <markus.rechberger@amd.com>

index b24efd4..bfc54a1 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -297,8 +297,7 @@ firmware_class_timeout(u_long data)
 
 static inline void fw_setup_device_id(struct device *f_dev, struct 
device *dev)
 {
-       /* XXX warning we should watch out for name collisions */
-       strlcpy(f_dev->bus_id, dev->bus_id, BUS_ID_SIZE);
+       snprintf(f_dev->bus_id, BUS_ID_SIZE, "fw-%s", dev->bus_id);
 }
 
 static int fw_register_device(struct device **dev_p, const char *fw_name,

Markus



             reply	other threads:[~2007-08-13 15:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-13 13:11 Markus Rechberger [this message]
2007-08-13 13:22 ` [PATCH] Firmware class name collision Jean Delvare
2007-08-13 17:10 ` Marcel Holtmann
2007-08-13 17:20   ` Markus Rechberger
2007-08-13 17:45     ` Marcel Holtmann
2007-08-14 13:33     ` Jean Delvare
2007-08-14 14:17       ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C05896.4050509@amd.com \
    --to=markus.rechberger@amd.com \
    --cc=greg@kroah.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.