From: Jeff Garzik <jgarzik@pobox.com>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Arjan van de Ven <arjan@infradead.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment
Date: Tue, 14 Aug 2007 01:05:38 -0400 [thread overview]
Message-ID: <46C13822.7040803@pobox.com> (raw)
In-Reply-To: <200708081320.26756.m.kozlowski@tuxland.pl>
Mariusz Kozlowski wrote:
> Hello,
>
> Unpatched version does sth like this:
>
> dev = alloc_etherdev(...
> private = netdev_priv(dev);
> ...
> dev->priv = private;
>
> which doesn't make much sense (does it?) because this is done in
> alloc_netdev() already.
>
> struct net_device *alloc_netdev(...
> {
> ...
> if (sizeof_priv)
> dev->priv = netdev_priv(dev);
>
> This patch removes superfluous code.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
applied
prev parent reply other threads:[~2007-08-14 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 11:20 [PATCH] net/tulip/xircom_cb.c: remove superfulous priv assignment Mariusz Kozlowski
2007-08-08 20:14 ` Arjan van de Ven
2007-08-14 5:05 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C13822.7040803@pobox.com \
--to=jgarzik@pobox.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.