Re: [patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet

[Jeff Garzik <jeff@garzik.org>]

akpm@linux-foundation.org wrote:
> From: "Peter Oruba" <peter.oruba@amd.com>
> 
> These driver changes incorporate the proposed PCI-X / PCI-Express read byte
> count interface.  Reading and setting those valuse doesn't take place
> "manually", instead wrapping functions are called to allow quirks for some
> PCI bridges.
> 
> Signed-off by: Peter Oruba <peter.oruba@amd.com>
> Based on work by Stephen Hemminger <shemminger@linux-foundation.org>
> Cc: Roland Dreier <rolandd@cisco.com>
> Cc: Brice Goglin <brice@myri.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/net/myri10ge/myri10ge.c |    3 +--
>  1 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff -puN drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet drivers/net/myri10ge/myri10ge.c
> --- a/drivers/net/myri10ge/myri10ge.c~pci-x-pci-express-read-control-interfaces-myrinet
> +++ a/drivers/net/myri10ge/myri10ge.c
> @@ -2884,8 +2884,7 @@ static int myri10ge_probe(struct pci_dev
>  			status);
>  		goto abort_with_netdev;
>  	}
> -	val = (val & ~PCI_EXP_DEVCTL_READRQ) | (5 << 12);
> -	status = pci_write_config_word(pdev, cap + PCI_EXP_DEVCTL, val);
> +	status = pcie_set_readrq(pdev, 4096);


I presume Brice will resend this one to me, next time he pushes...