All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Philip Craig <philipc@snapgear.com>
Cc: Netfilter Developer Mailing List <netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH][CTNETLINK] Include the id in conntrack netlink events.
Date: Tue, 14 Aug 2007 08:34:06 +0200	[thread overview]
Message-ID: <46C14CDE.5030803@trash.net> (raw)
In-Reply-To: <46C14B05.2000200@snapgear.com>

Philip Craig wrote:
> Patrick McHardy wrote:
>   
>> Philip Craig wrote:
>>     
>>> I need the id in ctnetlink events for my application, so here's a
>>> patch to add it in case this wasn't left out intentionally.
>>>   
>> It was, we have plans to remove it. What for do you need it
>> exactly?
>
> So it won't be needed for dumping either?

No, I removed that in 2.6.23-rc.

>
> It's just a simple way of matching up events, so that I can log both
> start and finish time, as well as the other details.
>
> The alternative is to cache the tuples in userspace and match on them,
> but that is significantly more complicated.  And caching requires
> more memory usage than having an id in the kernel.
>   

True, but its quite a waste in the kernel as well when considering
that almost nobody needs this. I was thinking about derriving a
unique ID just for userspace from the conntrack address (in memory).
Its not unique over time, just as tuples aren't, but when combined
with the tuples it should only clash very rarely, and you'll always
get a DESTROY + NEW event before a clash. Would that work for you?

  parent reply	other threads:[~2007-08-14  6:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-14  5:07 [PATCH][CTNETLINK] Include the id in conntrack netlink events Philip Craig
2007-08-14  6:01 ` Patrick McHardy
     [not found]   ` <46C14B05.2000200@snapgear.com>
2007-08-14  6:34     ` Patrick McHardy [this message]
2007-08-14  7:03       ` Philip Craig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C14CDE.5030803@trash.net \
    --to=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=philipc@snapgear.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.