From: Eric Sandeen <sandeen@redhat.com>
To: Bodo Eggert <7eggert@gmx.de>
Cc: linux-kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
security@kernel.org
Subject: Re: [PATCH V3] limit minixfs printks on corrupted dir i_size, CVE-2006-6058
Date: Wed, 15 Aug 2007 09:59:34 -0500 [thread overview]
Message-ID: <46C314D6.6090402@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0708151345220.3232@be1.lrz>
Bodo Eggert wrote:
>> Ok, do you like this slightly better? It states the subsystem, the
>> function with the error, the block nr. in the case of a too-large block,
>> and the block device on which the error occurred.
>
> - how long is BDEVNAME_SIZE? Will it fit on the stack?
#define BDEVNAME_SIZE 32 /* Largest string for a blockdev
identifier */
~60 other users in md, ext3, jbd, buffer.c, etc. place it on the stack...
> - Does it include thespace for \0?
bdevname calls disk_name which does snprintf(buf, BDEVNAME_SIZE, ...),
so yes.
-Eric
> I asume you copied other users, and the other users will do it right (or
> at least not terribly wrong:), but I can't dig the code right now.
>
>> Honestly minix.fsck
>> doesn't handle the situation well either, so at this point I hesitate
>> to recommend it in the print. :)
>
> *g*
prev parent reply other threads:[~2007-08-15 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8Qlff-3jX-29@gated-at.bofh.it>
[not found] ` <8Qn7m-6li-27@gated-at.bofh.it>
2007-08-09 21:47 ` [PATCH V2] limit minixfs printks on corrupted dir i_size, CVE-2006-6058 Bodo Eggert
2007-08-09 21:47 ` Bodo Eggert
2007-08-09 22:08 ` Eric Sandeen
2007-08-13 17:54 ` [PATCH V3] " Eric Sandeen
2007-08-15 11:51 ` Bodo Eggert
2007-08-15 14:59 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C314D6.6090402@redhat.com \
--to=sandeen@redhat.com \
--cc=7eggert@gmx.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.