Re: [PATCH] libata-core: support wildcard matching in ata_blacklist_entry

[Jeff Garzik <jeff@garzik.org>]

Alan Cox wrote:
> On Wed, 8 Aug 2007 15:20:57 -0500
> David Milburn <dmilburn@redhat.com> wrote:
> 
>> Support the use of '*' in model_num and model_rev entries
>> in ata_device_blacklist[].
>>
>> CC: alan@lxorguk.ukuu.org.uk
>> Signed-off-by: David Milburn <dmilburn@redhat.com>
> 
> Suggestion: Pull the match function out of line so you don't have two
> copies of it and can remove all the wacky ? operators
> 
> something like this ? (untested)
> 
> 	strpatterncmp(const char *name, const char *patt)
> 	{
> 		const char *p = strchr(patt, '*');
> 		if (p == NULL)
> 			p = patt + strlen(patt);
> 		return strncmp(name, patt, p-patt);
> 	}

Seems quite sane to me...

And I support the addition of wildcard operators; that should make 
maintenance a bit easier.