From: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: Zhang Rui <rui.zhang@intel.com>,
lenb@kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 06/12] ACPI: Add acpi_bus_generate_event4() function
Date: Fri, 17 Aug 2007 09:48:04 +0400 [thread overview]
Message-ID: <46C53694.1010802@suse.de> (raw)
In-Reply-To: <46C52E05.2090404@gmail.com>
Alexey Starikovskiy wrote:
> Zhang Rui wrote:
>
>> On Thu, 2007-08-16 at 18:03 +0400, Alexey Starikovskiy wrote:
>>
>>> From: Alexey Starikovskiy <astarikovskiy@suse.de>
>>>
>>> acpi_bus_generate_event() takes two strings out of passed device object.
>>> SBS needs to supply these strings directly.
>>>
>>>
>> This doesn't make sense.
>>
How much sense in sending different bus_id from the same device?
>> acpi_dev->dev.bus_id is the name we are using for ACPI device in sysfs.
>> That's why acpi_dev->dev.bus_id is exported via netlink message rather
>> than the acpi_dev.pnp.bus_id.
>> BTW: what's wrong with the old acpi_sbs_generate_event thing?
>>
> There are up to 5 devices in SBS which could send a message.
> From ACPI point of view this is one device.
> Copying strings before and after sending event seems to be mess to me.
Regards,
Alex.
next prev parent reply other threads:[~2007-08-17 5:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 14:03 [PATCH 01/12] ACPI: AC: Add sysfs interface Alexey Starikovskiy
2007-08-16 14:03 ` [PATCH 02/12] ACPI: Battery: don't use acpi_extract_package() Alexey Starikovskiy
2007-08-16 14:03 ` [PATCH 03/12] ACPI: Battery: simplify update scheme Alexey Starikovskiy
2007-08-16 14:03 ` [PATCH 04/12] ACPI: Battery: Misc clean-ups, no functional changes Alexey Starikovskiy
2007-08-16 14:03 ` [PATCH 05/12] ACPI: Battery: Add sysfs support Alexey Starikovskiy
2007-08-16 14:03 ` [PATCH 06/12] ACPI: Add acpi_bus_generate_event4() function Alexey Starikovskiy
2007-08-17 2:23 ` Zhang Rui
2007-08-17 5:11 ` Alexey Starikovskiy
2007-08-17 5:48 ` Alexey Starikovskiy [this message]
2007-08-17 6:25 ` Zhang Rui
2007-08-16 14:03 ` [PATCH 07/12] ACPI: EC: Add new query handler to list head Alexey Starikovskiy
2007-08-16 14:03 ` [PATCH 08/12] ACPI: SBS: Split host controller (ACPI0001) from SBS driver (ACPI0002) Alexey Starikovskiy
2007-08-16 14:04 ` [PATCH 09/12] ACPI: SBS: Simplify data structures in SBS Alexey Starikovskiy
2007-08-16 14:04 ` [PATCH 10/12] ACPI: SBS: Make SBS reads table-driven Alexey Starikovskiy
2007-08-16 14:04 ` [PATCH 11/12] ACPI: SBS: Add support for power_supply class (and sysfs) Alexey Starikovskiy
2007-08-16 14:04 ` [PATCH 12/12] ACPI: SBS: Add ACPI_PROCFS around procfs handling code Alexey Starikovskiy
-- strict thread matches above, loose matches on Subject: below --
2007-08-16 14:25 [PATCH 01/12] ACPI: AC: Add sysfs interface Alexey Starikovskiy
2007-08-16 14:26 ` [PATCH 06/12] ACPI: Add acpi_bus_generate_event4() function Alexey Starikovskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C53694.1010802@suse.de \
--to=astarikovskiy@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.