From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/8] alim15x3: PIO fallback fix
Date: Sat, 18 Aug 2007 23:26:11 +0400 [thread overview]
Message-ID: <46C747D3.3040106@ru.mvista.com> (raw)
In-Reply-To: <200708182118.23591.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
>>>[PATCH] alim15x3: PIO fallback fix
>>>If DMA tuning fails always set the best PIO mode.
>>>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>>Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>> Oh, it's belated now. :-/
> a bit ;)
Kept deferring the reviews until I've totally forgotten. ;-)
>> BTW, I'm going to hack on this driver since I've acquired a board with
>>M1543C chip (that one for which there was an urgent bug that I had to fix some
>>weeks ago :-)...
>
>
> Cool, this driver still have much room for an improvement i.e. it lacks proper
> MWDMA support and would greatly benefit from using ide_timing_compute()...
Oh, that can be said about alomost all DMA-capable chip drivers except
AMD/VIA. So, don't hold your breath -- the first things on my agenda is
fixing PIO timings (address setup being wrongly accounted for again) and
adding the claimed MWDMA support per se.
> Bart
WBR, Sergei
next prev parent reply other threads:[~2007-08-18 19:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 1:56 [PATCH 1/8] alim15x3: PIO fallback fix Bartlomiej Zolnierkiewicz
2007-02-14 1:56 ` [PATCH 2/8] alim15x3: use ide_tune_dma() Bartlomiej Zolnierkiewicz
2007-02-14 1:56 ` [PATCH 3/8] pdc202xx_new: " Bartlomiej Zolnierkiewicz
2007-02-14 1:56 ` [PATCH 4/8] ide: remove some obsoleted kernel params Bartlomiej Zolnierkiewicz
2007-02-14 1:56 ` [PATCH 5/8] ide: add "initializing" argument to ide_register_hw() Bartlomiej Zolnierkiewicz
2007-02-14 1:57 ` [PATCH 6/8] ide: add ide_proc_register_port() Bartlomiej Zolnierkiewicz
2007-02-14 1:57 ` [PATCH 7/8] ide: make legacy IDE VLB modules check for the "probe" kernel params Bartlomiej Zolnierkiewicz
2007-02-14 10:53 ` Alan
2007-02-14 11:07 ` Bartlomiej Zolnierkiewicz
2007-02-14 11:17 ` Alan
2007-02-14 11:19 ` Bartlomiej Zolnierkiewicz
2007-02-14 19:52 ` [PATCH 7/8] ide: make legacy IDE VLB modules check for the "probe" kernel params (v2) Bartlomiej Zolnierkiewicz
2007-02-14 1:57 ` [PATCH 8/8] ide: fix ide.c Bartlomiej Zolnierkiewicz
2007-08-18 13:50 ` [PATCH 1/8] alim15x3: PIO fallback fix Sergei Shtylyov
2007-08-18 19:18 ` Bartlomiej Zolnierkiewicz
2007-08-18 19:26 ` Sergei Shtylyov [this message]
2007-11-09 16:58 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C747D3.3040106@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.