From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] omap2420h4 error
Date: Sun, 19 Aug 2007 19:05:59 +0200 [thread overview]
Message-ID: <46C87877.2000107@googlemail.com> (raw)
Looking at arm-errors.tar.gz -> omap2420h4.ERR
common/libcommon.a(env_flash.o): In function `env_init':
/.automount/castor-vlab/root/home/wd/git/u-boot/work/common/env_flash.c:265:
undefined reference to `flash_probe'
make: *** [/work/wd/tmp/u-boot-arm/u-boot] Error 1
is because in board/omap2420h4 file flash.c isn't used any more. This
file contains flash_probe(), but it isn't compiled. If enabled for
test, there are tons of link conflicts with cfi_flash.c.
So looks to me that omap2420h4 switch to cfi disabled flash.c (and
didn't remove it) but missed to resolve flash_probe() call in env_flash.c.
http://www.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=49a7581c6ced35379ec3c450bb60fe736db9d733
Proposal to fix this is to remove unused file board/omap2420h4/flash.c
and remove calls of flash_probe()/omap2420h4 #ifdefs in env_flash.c.
However, not sure if this is correct.
Opinions?
Cheers
Dirk
next reply other threads:[~2007-08-19 17:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-19 17:05 Dirk Behme [this message]
2007-08-19 20:06 ` [U-Boot-Users] omap2420h4 error Nishanth Menon
2007-08-19 20:53 ` Wolfgang Denk
2007-08-20 5:09 ` [U-Boot-Users] [PATCH] " Dirk Behme
2007-08-29 0:02 ` Wolfgang Denk
2007-08-19 20:24 ` [U-Boot-Users] " Woodruff, Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C87877.2000107@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.