All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@nokia.com>
To: ext Trilok Soni <soni.trilok@gmail.com>
Cc: Linux OMAP <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH 1/2] ov9640: Add OmniVision ov9640 driver - new interface
Date: Mon, 20 Aug 2007 12:07:42 +0300	[thread overview]
Message-ID: <46C959DE.2010306@nokia.com> (raw)
In-Reply-To: <5d5443650708180136o56e3cfc8t458a7071d88c0288@mail.gmail.com>

ext Trilok Soni wrote:
> Hi All,

Hi, Trilok!

> I have attached two patches which converts the ov9640 driver to use
> the new v4l2 sensor interface. Sensor detection is working with H4 but
> the output is not anywhere near to correct, so someone with H4 please
> check and give inputs.
> 
> Patches are implemented and tested against mainline kernel and OMAP2
> camera driver posted by Sakari to v4l mailing list [1].

 > +#define NUM_IOCTLS 16
...
 > +     /* Just an experiment --- don't use *_cb functions yet. */
 > +     ov9640_ioctl_desc[i++] = vidioc_int_dev_init_cb(&ioctl_dev_init);
 > +     BUG_ON(i >= NUM_IOCTLS);

These are leftovers from the check-slave-interface-types experiment 
which probably should be removed. This applies to TCM825x as well.

-- 
Sakari Ailus
sakari.ailus@nokia.com

  reply	other threads:[~2007-08-20  9:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-18  8:36 [PATCH 1/2] ov9640: Add OmniVision ov9640 driver - new interface Trilok Soni
2007-08-20  9:07 ` Sakari Ailus [this message]
2007-08-20 10:21   ` Trilok Soni
2007-08-23 12:29     ` Trilok Soni
2007-08-27 18:39       ` OSK5912 Boot from CF? Hingkwan Huen
2007-08-27 19:04         ` Dirk Behme
2007-08-27 19:12           ` Hingkwan Huen
2007-08-27 19:22             ` Dirk Behme
2007-08-27 19:37             ` David Brownell
2007-08-31 20:27       ` [PATCH 1/2] ov9640: Add OmniVision ov9640 driver - new interface Tony Lindgren
2007-09-02  9:59         ` Trilok Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C959DE.2010306@nokia.com \
    --to=sakari.ailus@nokia.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=soni.trilok@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.