From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: chrisw@sous-sol.org, virtualization@lists.osdl.org,
Andrew Morton <akpm@linux-foundation.org>,
xen-devel@lists.xensource.com, jeremy@xensource.com
Subject: Re: [PATCH] Xen i386 xen-head.S fix sections mixup (updated)
Date: Mon, 20 Aug 2007 10:34:44 -0700 [thread overview]
Message-ID: <46C9D0B4.5060300@goop.org> (raw)
In-Reply-To: <20070820171912.GB9478@Krystal>
Mathieu Desnoyers wrote:
> Xen i386 xen-head.S fix sections mixup
>
> xen-head.S does not come back to the data section, leaving the text section
> as current section. It causes problems with a slightly enhanced DEBUG_RODATA
> that supports CONFIG_HOTPLUG and bringing a CPU up after the text has been
> marked read-only: reference to early_gdt_descr causes a page fault.
>
> Update:
>
> It should be using pushsection/popsection.
>
Looks good, with one caveat below.
Acked-by: Jeremy Fitzhardinge <jeremy@xensource.com>
> - .section .text
> +.pushsection .text
> ELFNOTE(Xen, XEN_ELFNOTE_GUEST_OS, .asciz "linux")
> ELFNOTE(Xen, XEN_ELFNOTE_GUEST_VERSION, .asciz "2.6")
> ELFNOTE(Xen, XEN_ELFNOTE_XEN_VERSION, .asciz "xen-3.0")
> @@ -34,5 +35,6 @@ ENTRY(hypercall_page)
> ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE, .asciz "no")
> #endif
> ELFNOTE(Xen, XEN_ELFNOTE_LOADER, .asciz "generic")
> +.popsection
>
Actually, the push/popsections around the ELFNOTEs are redundant;
ELFNOTE() does its own push/popsection to put things into the
appropriate .note* section anyway.
J
next prev parent reply other threads:[~2007-08-20 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 3:04 [PATCH] Xen i386 xen-head.S fix sections mixup Mathieu Desnoyers
2007-08-20 6:13 ` Jeremy Fitzhardinge
2007-08-20 17:19 ` [PATCH] Xen i386 xen-head.S fix sections mixup (updated) Mathieu Desnoyers
2007-08-20 17:34 ` Jeremy Fitzhardinge [this message]
2007-08-20 19:04 ` [PATCH] Xen i386 xen-head.S fix sections mixup (update 2) Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C9D0B4.5060300@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=chrisw@sous-sol.org \
--cc=jeremy@xensource.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.