From mboxrd@z Thu Jan 1 00:00:00 1970 From: Varun Chandramohan Subject: Re: [PATCH 3/4 - rev 2] Initilize and populate age field Date: Tue, 21 Aug 2007 17:02:29 +0530 Message-ID: <46CACD4D.3010408@linux.vnet.ibm.com> References: <20070820134617.1226c97b.varunc@linux.vnet.ibm.com> <20070821105542.GN32236@postel.suug.ch> <46CACAFB.8050709@linux.vnet.ibm.com> <20070821112735.GO32236@postel.suug.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, kaber@trash.net, socketcan@hartkopp.net, shemminger@linux-foundation.org, krkumar2@in.ibm.com, varuncha@in.ibm.com To: Thomas Graf Return-path: Received: from e2.ny.us.ibm.com ([32.97.182.142]:44165 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754159AbXHULbz (ORCPT ); Tue, 21 Aug 2007 07:31:55 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l7LBVtEX028260 for ; Tue, 21 Aug 2007 07:31:55 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l7LBVt8C453716 for ; Tue, 21 Aug 2007 07:31:55 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l7LBVriL022667 for ; Tue, 21 Aug 2007 07:31:54 -0400 In-Reply-To: <20070821112735.GO32236@postel.suug.ch> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Thomas Graf wrote: > * Varun Chandramohan 2007-08-21 16:52 > >> I know its a bit confusing but let me explain the reason. In my first >> version patch i used fn_hash_insert() (place where alias is created)as >> place to insert my current time in the age field. >> This will eventually call fib_dump_info() for inserting the age filed >> attribute into the skb. Now in both places i have to call >> do_gettimeofday(). Its obvious that i need it in fn_hash_insert(), its >> also need in fib_dump_info() as it is the same function called for >> retrieving and dumping the age value to the userspace. So as you are >> aware that before we dump it to userspace we need to subtract the value >> with current time i need to call do_gettimeofday() twice. To avoid this >> i did as above. >> > > At least put a comment there, it's far from obvious. > ok, thanks for the suggestion. Ill put a comment on that. > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >