All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <James.Smart@Emulex.Com>
To: Christof Schmitt <christof.schmitt@de.ibm.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [RFC] FC transport: Disable LUN scanning from low level driver
Date: Tue, 21 Aug 2007 09:03:17 -0400	[thread overview]
Message-ID: <46CAE295.2050404@emulex.com> (raw)
In-Reply-To: <20070821123640.GA4821@schmichrtp.de.ibm.com>


Nit (but preferred) : change "no_target_scan" to "disable_target_scan".
Otherwise, patch is good.

Christof Schmitt wrote:
> I attached a new patch that adds a flag to the fc template. So far, it
> is untested. What is the better approach? Avoid scanning with the flag
> being 1 or use the 1 to enable scaning and make this change in all FC
> drivers?

1 to disable. Avoid changing the drivers...

> We had the discussion about zfcp inventing LUNs in the past
> (http://www.spinics.net/lists/linux-scsi/msg17125.html).

Yep.  However, I don't agree with Hannes in this case.  Given that the
firmware is already doing funky things to share the real adapter, I
believe it (or the driver) should do the right thing in the LUN
presentation to keep the system happy. But - I guess that's something
for a different time.

-- james s


  reply	other threads:[~2007-08-21 13:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-20 11:21 [RFC] FC transport: Disable LUN scanning from low level driver Christof Schmitt
2007-08-21  1:07 ` James Smart
2007-08-21 12:36   ` Christof Schmitt
2007-08-21 13:03     ` James Smart [this message]
2007-08-21 15:31       ` Christof Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46CAE295.2050404@emulex.com \
    --to=james.smart@emulex.com \
    --cc=christof.schmitt@de.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.