From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <jbeulich@novell.com>
Subject: Re: [PATCH] 3/3: MCA/MCE correctable error
	handling
Date: Tue, 21 Aug 2007 17:02:54 +0100
Message-ID: <46CB28CE.76E4.0078.0@novell.com>
References: <200708211531.44997.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200708211531.44997.Christoph.Egger@amd.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: Gavin.Maltby@sun.com, xen-devel@lists.xensource.com, Keir Fraser <keir@xensource.com>
List-Id: xen-devel@lists.xenproject.org

>+		if (mc_global->mc_flags & MC_FLAG_UNCORRECTABLE)
>+			printk(KERN_EMERG);
>+		else
>+			printk(KERN_INFO);

KERN_INFO seems gross understatement here - generally, correctable MCs are
considered indicators that within not too distant future uncorrectable MCs =
might
result, so this generally is a call for action (and hence shouldn't be =
hidden with
default log level settings).

Also, I'm not sure adjusting the polling frequency makes much sense - 30s =
seems
an awful lot of time to me.

Jan