From: Boaz Harrosh <bharrosh@panasas.com>
To: Doug Maxey <dwm@enoyolf.org>
Cc: "Björn Stenberg" <bjorn@haxx.se>,
support@in-system.com,
"James Bottomley" <James.Bottomley@SteelEye.com>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: isd200.c Has fatal bugs and is probably not used any more
Date: Wed, 22 Aug 2007 12:18:53 +0300 [thread overview]
Message-ID: <46CBFF7D.2090904@panasas.com> (raw)
In-Reply-To: <29728.1187727861@bebe.enoyolf.org>
Doug Maxey wrote:
> On Tue, 21 Aug 2007 22:06:26 +0300, Boaz Harrosh wrote:
>> Hi!
>>
>> the driver drivers/usb/storage/isd200.c has code like:
>>
>> static int isd200_action( struct us_data *us, int action,
>> void* pointer, int value )
>>
>> ...
>>
>> case ACTION_READ_STATUS:
>> US_DEBUGP(" isd200_action(READ_STATUS)\n");
>> ata.generic.ActionSelect = ACTION_SELECT_0|ACTION_SELECT_2;
>> ata.generic.RegisterSelect =
>> REG_CYLINDER_LOW | REG_CYLINDER_HIGH |
>> REG_STATUS | REG_ERROR;
>> srb->sc_data_direction = DMA_FROM_DEVICE;
>> srb->request_buffer = pointer;
>> srb->request_bufflen = value;
>> break;
>> ...
>>
>> Now what the hell is that hijacked scsi_cmnd and who said
>> that the srb->use_sg is Zero. If this is a regular queued
>> scsi_cmnd, this can easily crash. And at best a memory leak.
>>
>> The last git recorded real change to this driver was it's insertion
>> into git by Linus.
>>
>> Is this an indication that this driver is no longer used and
>> can be removed?
>
> All IBM bladecenters have the HW this driver supports. And it does
> mostly work. This particular frag requires USB_DEBUG enabled, correct?
>
OK Thanks, Do you know if there is an active maintainer for this driver?
Else I will need someone that can test patches for me.
Boaz
next prev parent reply other threads:[~2007-08-22 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 19:06 isd200.c Has fatal bugs and is probably not used any more Boaz Harrosh
2007-08-21 20:24 ` Doug Maxey
2007-08-22 9:18 ` Boaz Harrosh [this message]
2007-08-22 8:42 ` Björn Stenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CBFF7D.2090904@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@SteelEye.com \
--cc=bjorn@haxx.se \
--cc=dwm@enoyolf.org \
--cc=gregkh@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=support@in-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.