All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Theurer <habanero@us.ibm.com>
To: "David S. Miller" <davem@davemloft.net>,
	Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: netdev@vger.kernel.org
Subject: eHEA driver issues from net-2.6.24
Date: Wed, 22 Aug 2007 16:55:03 -0500	[thread overview]
Message-ID: <46CCB0B7.3030302@us.ibm.com> (raw)

In testing the new NAPI improvements on ehea, I get the following:

kernel BUG at include/linux/netdevice.h:318!
cpu 0x1: Vector: 700 (Program Check) at [c00000000f613ac0]
    pc: d000000000091054: .ehea_poll+0x1e8/0x1334 [ehea]
    lr: c0000000003fe394: .net_rx_action+0x1b8/0x254
    sp: c00000000f613d40
   msr: 8000000000029032
  current = 0xc0000005aff9e8b0
  paca    = 0xc0000000006e1300
    pid   = 0, comm = swapper
kernel BUG at include/linux/netdevice.h:318!
enter ? for help
[c00000000f613e40] c0000000003fe394 .net_rx_action+0x1b8/0x254
[c00000000f613ef0] c000000000057b70 .__do_softirq+0xa8/0x164
[c00000000f613f90] c000000000024438 .call_do_softirq+0x14/0x24
[c000000b8ffbf9f0] c00000000000bd30 .do_softirq+0x68/0xac
[c000000b8ffbfa80] c000000000057cc4 .irq_exit+0x54/0x6c
[c000000b8ffbfb00] c00000000000c358 .do_IRQ+0x170/0x1ac
[c000000b8ffbfb90] c000000000004780 hardware_interrupt_entry+0x18/0x98
--- Exception: 501 (Hardware Interrupt) at c000000000010bdc 
.cpu_idle+0x114/0x1e0
[c000000b8ffbfe80] c000000000010bd0 .cpu_idle+0x108/0x1e0 (unreliable)
[c000000b8ffbff00] c000000000026db0 .start_secondary+0x160/0x184
[c000000b8ffbff90] c000000000008364 .start_secondary_prolog+0xc/0x10


I'm a little confused if the port_napi_enable() is being called when the 
device is initialized, but then again, this is all new to me (should it 
be called in ehea_open?).  I see it called on some reset routines, but 
not on the first initialization.


Also, on this code, in ehea_sense_port_attr()

/* Number of default QPs */
        if (use_mcs)
                port->num_def_qps = cb0->num_default_qps;
        else
                port->num_def_qps = 1;
               

When using napi, since we have multi-queue napi support now, wouldn't we 
want to use all the default qps instead of 1?

Thanks,

-Andrew




 

             reply	other threads:[~2007-08-22 21:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-22 21:55 Andrew Theurer [this message]
2007-08-22 22:03 ` eHEA driver issues from net-2.6.24 David Miller
2007-08-22 22:20   ` Andrew Theurer
2007-08-23  6:55     ` Jan-Bernd Themann
2007-08-23  8:17       ` David Miller
2007-08-23  7:56         ` Jan-Bernd Themann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46CCB0B7.3030302@us.ibm.com \
    --to=habanero@us.ibm.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=ossthema@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.