Memory leak in cpufreq-nforce2.c

[GW <gw.kernel@tnode.com>]

Hello.

I accidentally found something missing in cpufreq-nforce2.c and asked on linux-pci mailing list about it:

Greg KH wrote:
> On Wed, Aug 22, 2007 at 11:27:29PM +0200, GW wrote:
>> I was wondering if after every usage of pci_get_subsys() when you
>> don't need the device anymore you need to call pci_dev_put(dev)?
> 
> Yes, that is a requirement.
> 
> I don't understand why you would think it would not be necessary.

This means that there are some memory leaks in the following driver that uses pci_get_subsys(), but no pci_dev_put():

arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c
  in function nforce2_fsb_read()
  in function __exit nforce2_exit(), because in __init nforce2_init() it calls nforce2_detect_chipset() that doesn't release the device

I don't have this chip, therefore I couldn't test a patch if I would written it.


    gw