From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mxser: Remove commented crap
Date: Thu, 23 Aug 2007 14:32:17 -0700 [thread overview]
Message-ID: <46CDFCE1.6080203@goop.org> (raw)
In-Reply-To: <20070822230257.4008820a@the-village.bc.nu>
Alan Cox wrote:
> This is years dead code and it keeps turning up in confusing ways when
> grepping for stuff
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc3-mm1/drivers/char/mxser.c linux-2.6.23rc3-mm1/drivers/char/mxser.c
> --- linux.vanilla-2.6.23rc3-mm1/drivers/char/mxser.c 2007-08-13 13:27:52.000000000 +0100
> +++ linux-2.6.23rc3-mm1/drivers/char/mxser.c 2007-08-22 17:47:05.000000000 +0100
> @@ -1938,14 +1938,6 @@
> inb(info->base + UART_MSR);
> continue;
> }
> - /* above add by Victor Yu. 09-13-2002 */
> - /*
> - if (info->tty->flip.count < TTY_FLIPBUF_SIZE / 4) {
> - info->IER |= MOXA_MUST_RECV_ISR;
> - outb(info->IER, info->base + UART_IER);
> - }
> - */
> -
>
> /* mask by Victor Yu. 09-13-2002
> if ( !info->tty ||
>
Looks like another block of commented code starting here...
J
prev parent reply other threads:[~2007-08-23 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-22 22:02 [PATCH] mxser: Remove commented crap Alan Cox
2007-08-23 21:32 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CDFCE1.6080203@goop.org \
--to=jeremy@goop.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.