Re: [patch 2.6.23-rc3-git] SPI driver hotplug/coldplug fixes

[Andrei Konovalov <akonovalov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>]

David Brownell wrote:
> Update various SPI drivers so they properly support
> 
>   - coldplug through "modprobe $(cat /sys/devices/.../modalias)"
> 
>   - hotplug through "modprobe $(MODALIAS)"
> 
> The basic rule for platform, SPI, and (new style) I2C drivers is just
> to make sure that modprobing the driver name works.  In this case, all
> the relevant drivers are platform drivers, and this patch either
> 
>   (a)	Changes the driver name, if no in-tree code would break;
> 	this is simpler and thus preferable in the long term.
> 
>   (b)	Adds MODULE_ALIAS directives, when in-tree platforms declare
> 	devices using the current driver name; less desirable.
> 
> Most systems will link SPI controller drivers statically, but
> there's no point in being needlessly broken.
> 
> Signed-off-by: David Brownell <dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
> ---
> Build-tested for the ARM drivers.
> 
>  drivers/spi/spi_bfin5xx.c      |    3 ++-
>  drivers/spi/spi_imx.c          |    2 +-
>  drivers/spi/spi_mpc83xx.c      |    1 +
>  drivers/spi/spi_s3c24xx.c      |    1 +
>  drivers/spi/spi_s3c24xx_gpio.c |    2 +-
>  drivers/spi/spi_txx9.c         |    1 +
>  drivers/spi/xilinx_spi.c       |    2 +-
>  7 files changed, 8 insertions(+), 4 deletions(-)

<snip>
> --- g26.orig/drivers/spi/xilinx_spi.c	2007-08-11 11:48:09.000000000 -0700
> +++ g26/drivers/spi/xilinx_spi.c	2007-08-11 12:13:19.000000000 -0700
> @@ -21,7 +21,7 @@
>  
>  #include <syslib/virtex_devices.h>
>  
> -#define XILINX_SPI_NAME "xspi"
> +#define XILINX_SPI_NAME "xilinx_spi"
>  
>  /* Register definitions as per "OPB Serial Peripheral Interface (SPI) (v1.00e)
>   * Product Specification", DS464

Acked-by: Andrei Konovalov <akonovalov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>

I'll add the corresponding modifications to the device registration stuff
for the Xilinx boards to git://source.mvista.com/git/linux-xilinx-26.git shortly.

Thanks,
Andrei

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/