All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: neilb@suse.de, nfs@lists.sourceforge.net
Subject: Re: [PATCH 2/9] mount.nfs: Don't allow the user to specify addr= or clientaddr=.
Date: Fri, 24 Aug 2007 14:16:40 -0400	[thread overview]
Message-ID: <46CF2088.3080903@oracle.com> (raw)
In-Reply-To: <20070824172529.GA6690@fieldses.org>

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

J. Bruce Fields wrote:
> On Fri, Aug 24, 2007 at 01:11:16PM -0400, Chuck Lever wrote:
>> The current mount.nfs implementation doesn't allow users to specify their
>> own addr= or clientaddr= option.
> 
> Don't we need clientaddr= in some cases to get the callback channel
> working?

The mount.nfs command adds a clientaddr option of its own before doing 
the syscall.  The point of the patch is to prevent passing in a 
user-created clientaddr=.

Does anyone know of a use case where an exposed clientaddr= is needed?

>> The new string-based interface does allow this, even though nfs(5)
>> does not document 'addr=' and specifically forbids adding
>> 'clientaddr='.
> 
> It says that it's currently ignored, which isn't the same as forbidding
> it.

nfs(5) is likely incorrect.  It's arguable what "currently ignored" 
means -- it probably means the mount command ignores it, if specified, 
and uses its own address anyway.

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 290 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2007-08-24 18:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-24 17:11 [PATCH 2/9] mount.nfs: Don't allow the user to specify addr= or clientaddr= Chuck Lever
2007-08-24 17:25 ` J. Bruce Fields
2007-08-24 18:16   ` Chuck Lever [this message]
2007-08-25 11:07     ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46CF2088.3080903@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=bfields@fieldses.org \
    --cc=neilb@suse.de \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.