From: Robert Hancock <hancockr@shaw.ca>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org,
Jesse Barnes <jesse.barnes@intel.com>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] Fix boot-time hang on G31/G33 PC
Date: Sun, 26 Aug 2007 11:59:13 -0600 [thread overview]
Message-ID: <46D1BF71.3020602@shaw.ca> (raw)
In-Reply-To: <20070826140743.GF14130@parisc-linux.org>
Matthew Wilcox wrote:
> On Sun, Aug 26, 2007 at 06:55:42AM -0600, Matthew Wilcox wrote:
>> On Sat, Aug 25, 2007 at 10:24:57PM -0600, Robert Hancock wrote:
>>> We've already got a patch for this in Greg's PCI tree, hopefully it
>>> should go in for 2.6.24.
>> I haven't seen it. I guess it wasn't sent to the PCI mailing list.
>>
>> Your patch had two or three problems with it; assuming we're talking
>> about the same patch.
>
> I found
> http://git.kernel.org/?p=linux/kernel/git/gregkh/patches.git;a=blob;f=pci/pci-disable-decode-of-io-memory-during-bar-sizing.patch;h=958ef4e837733206a80f058aee236847eec5fbd8;hb=HEAD
>
> which has two problems:
>
> - With a 64-bit BAR, it checks to see if the upper 32 bits represent IO
> or memory. You can't do that to the upper 32 bits.
> - It does a lot of additional writes to the cmd register; my patch does two
> writes per device; yours does two per BAR
>
> It's also a lot more complex than my patch, IMO.
>
> Greg, please drop Robert's patch and put mine in instead.
Based on looking at your patch it seems OK. The first problem you
mentioned with what Jesse and I had there is definitely a valid one.
You can add my:
Acked-by: Robert Hancock <hancockr@shaw.ca>
next prev parent reply other threads:[~2007-08-26 18:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-26 1:55 [PATCH] Fix boot-time hang on G31/G33 PC Matthew Wilcox
2007-08-26 4:24 ` Robert Hancock
2007-08-26 12:55 ` Matthew Wilcox
2007-08-26 14:07 ` Matthew Wilcox
2007-08-26 17:59 ` Robert Hancock [this message]
2007-08-28 17:22 ` Jesse Barnes
2007-08-28 17:59 ` Grant Grundler
2007-08-28 18:28 ` Grant Grundler
2007-09-26 21:18 ` PCI: " Greg KH
2007-09-26 21:55 ` Jesse Barnes
2007-09-26 21:56 ` Greg KH
2007-09-26 22:20 ` Jesse Barnes
2007-09-26 23:04 ` Robert Hancock
2007-09-27 14:31 ` Ivan Kokshaysky
2007-09-27 18:36 ` Kok, Auke
2007-09-27 23:13 ` Greg KH
2007-10-12 14:26 ` Vitaliy Gusev
2007-10-12 17:07 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D1BF71.3020602@shaw.ca \
--to=hancockr@shaw.ca \
--cc=greg@kroah.com \
--cc=jesse.barnes@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.