From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCHSET #upstream-fixes] libata: update HPA handling
Date: Mon, 27 Aug 2007 13:48:08 +0900 [thread overview]
Message-ID: <46D25788.4090907@gmail.com> (raw)
In-Reply-To: <46C4305B.5090106@gmail.com>
Tejun Heo wrote:
> Jeff Garzik wrote:
>> Tejun Heo wrote:
>>> Hello,
>>>
>>> The current HPA handling implementation isn't robust enough and causes
>>> regressions on several cases. This patchset contains HPA handling
>>> update.
>>>
>>> * blacklist devices which puke on READ_NATIVE_MAX
>>> * proper/better error handling - in most cases, HPA failure won't
>>> result in detection failure
>>> * re-read IDENTIFY data after resizing
>>> * more concise messages
>>>
>>> Tested by setting up HPA area manually.
>> This is a bit big for 2.6.23-rc though :/
>
> Agreed. We can probably just get away with ATA_HORKAGE_BROKEN_HPA patch
> for 2.6.23-rc but if we hit a device which is broken but isn't listed,
> libata will fail to detect the device, which is a pretty serious regression.
>
PING. Do you want me to separate out the blacklist patch for
#upstream-fixes and commit HPA error handling reimplementation only into
#upstream?
--
tejun
prev parent reply other threads:[~2007-08-27 4:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 18:05 [PATCHSET #upstream-fixes] libata: update HPA handling Tejun Heo
2007-08-15 18:06 ` [PATCH 1/4] libata: move ata_id_n_sectors() upward Tejun Heo
2007-08-15 18:07 ` [PATCH 2/4] libata: implement BROKEN_HPA horkage and apply to affected drives Tejun Heo
2007-08-15 18:22 ` Alan Cox
2007-08-15 18:21 ` Tejun Heo
2007-08-15 18:08 ` [PATCH 3/4] libata: clean up read/set native_max address functions Tejun Heo
2007-08-16 8:11 ` [PATCHSET #upstream-fixes] libata: update HPA handling Jeff Garzik
2007-08-16 11:09 ` Tejun Heo
2007-08-27 4:48 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D25788.4090907@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.