From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: arch_align_stack() seems useless
Date: Mon, 27 Aug 2007 16:08:31 +0200 [thread overview]
Message-ID: <46D2DADF.8060505@gmail.com> (raw)
Hello folks,
I recently pick up the implementation of arch_align_stack() from x86
architectures to make it available for mips.
But now I just realised that this function seems useless because of
the way it's used.
Currently, this function seems to be only used to randomize the stack
pointer inside a page during an execve() syscall. Only i386, x86_64
and recently mips do that. Here is the code taken from exec.c which
calls it:
int setup_arg_pages(struct linux_binprm *bprm,
unsigned long stack_top,
int executable_stack)
{
[...]
stack_top = arch_align_stack(stack_top);
stack_top = PAGE_ALIGN(stack_top);
[...]
}
Since PAGE_ALIGN() is called right after arch_align_stack(), it seems
to me that the call to the latter function is useless...
Am I missing something ?
thanks
Franck
next reply other threads:[~2007-08-27 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 14:08 Franck Bui-Huu [this message]
2007-08-27 14:14 ` arch_align_stack() seems useless Arjan van de Ven
2007-08-28 13:17 ` Franck Bui-Huu
2007-08-30 8:22 ` Franck Bui-Huu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D2DADF.8060505@gmail.com \
--to=vagabon.xyz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.