From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Massimo Di Nitto Date: Mon, 27 Aug 2007 19:38:37 +0200 Subject: [Cluster-devel] [PATCH] Cleanup some common CFLAGS In-Reply-To: <1188229540.3972.3.camel@technetium.msp.redhat.com> References: <46D1111C.1010803@ubuntu.com> <1188229540.3972.3.camel@technetium.msp.redhat.com> Message-ID: <46D30C1D.60009@ubuntu.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Bob Peterson wrote: > On Sun, 2007-08-26 at 07:35 +0200, Fabio Massimo Di Nitto wrote: >> The following patch does: >> >> - change the default CFLAGS to -Wall -O2 -g >> - add --debug option to configure that will override the default >> CFLAGS to -Wall -O0 -DDEBUG -g >> - clean up all the relevant Makefiles >> - add a few missing ; to configure script (almost cosmetic since >> perl didn't trip on them). >> >> NOTE that some subproject were using -ggdb with notes that had to be removed. >> This is basically the only "major" change in the set since it will switch to a >> more common -g. According to gcc 4.1 man page -g is still good enough to >> generate enough debugging information for gdb. >> >> Please ACK or apply. >> >> Fabio >> >> PS The patch depends on the previous Makefile cleanup I posted on the mailing >> list right before this one. > > ACK, but I only looked at the defaults and the gfs2 userland bits. > > Regards, > > Bob Peterson > Thanks, I will wait for another ACK before applying this one. Fabio -- I'm going to make him an offer he can't refuse.