From: Arjan van de Ven <arjan@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>,
Eugene Teo <eugeneteo@kernel.sg>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH] clean up exports in fs/{open,read_write}.c
Date: Mon, 27 Aug 2007 15:49:01 -0700 [thread overview]
Message-ID: <46D354DD.6000208@linux.intel.com> (raw)
In-Reply-To: <20070827213747.GA17049@infradead.org>
Christoph Hellwig wrote:
> On Fri, Aug 24, 2007 at 11:33:10AM +0800, Eugene Teo wrote:
>> Takashi-san fixed sound/isa/wavefront/wavefront_synth.c to use
>> request_firmware instead of sys_*. Since that is the last driver in the
>> kernel that uses sys_{read,close}, this patch kills these exports. sys_open
>> is left exported for sparc64 only.
>
> I can't find any spar user of it, so please kill it.
it's in the solaris compat code which is modular
> In the case a symbol
> is needed only for a particular architecture it's better to do it in the
> architecture-specific ksyms file than with an ifdef, btw.
agreed.
(well if it's only 1 or 2, if it's "half of them" it's obviously a
different story)
next prev parent reply other threads:[~2007-08-27 22:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 3:33 [PATCH] clean up exports in fs/{open,read_write}.c Eugene Teo
2007-08-27 21:37 ` Christoph Hellwig
2007-08-27 22:49 ` Arjan van de Ven [this message]
2007-08-28 12:26 ` Christoph Hellwig
2007-08-27 23:16 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D354DD.6000208@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=eugeneteo@kernel.sg \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.