From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Massimo Di Nitto Date: Tue, 28 Aug 2007 06:22:50 +0200 Subject: [Cluster-devel] [PATCH] Cleanup some common CFLAGS In-Reply-To: <20070827212210.GH17551@redhat.com> References: <46D1111C.1010803@ubuntu.com> <20070827212210.GH17551@redhat.com> Message-ID: <46D3A31A.9090308@ubuntu.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Lon Hohberger wrote: > On Sun, Aug 26, 2007 at 07:35:24AM +0200, Fabio Massimo Di Nitto wrote: >> diff -Naurd redhat-cluster-suite-2.20070823/cman/qdisk/Makefile cluster/cman/qdisk/Makefile >> --- redhat-cluster-suite-2.20070823/cman/qdisk/Makefile 2007-08-26 07:02:55.000000000 +0200 >> +++ cluster/cman/qdisk/Makefile 2007-08-26 07:10:30.000000000 +0200 >> @@ -13,7 +13,7 @@ >> include ../../make/defines.mk >> >> CFLAGS += -D_GNU_SOURCE >> -CFLAGS += -Werror -Wstrict-prototypes -Wshadow -g >> +CFLAGS += -Werror -Wstrict-prototypes -Wshadow >> CFLAGS += -I${ccsincdir} -I${cmanincdir} >> CFLAGS += -I. >> CFLAGS += -I${incdir} > > -DDEBUG is usually done by developers and is normally "printf" sort of > run-time debugging. > > In my mind, for most distributors, -g always needs to be done, even w/o > -DDEBUG in order for support personnel to able to look at core files. > > ACK if you've got a super easy to add CFLAGS, which it looks like you > do: > > ./configure --extracflags="-g" > > Once your patch is applied, I'll look at the stuff in rgmanager that > croaks with --debug enabled. With this patch -g becomes default via cflags so I assume it does what you are asking for. I agree with the DDEBUG stuff and that's why it is not turned on by default but you can either use the --extracflags or --debug that will turn off gcc optimizations and enable -DDEBUG. Fabio -- I'm going to make him an offer he can't refuse.