From: Eric Sandeen <sandeen@sandeen.net>
To: David Chinner <dgc@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] clean up vnode^winode tracing
Date: Tue, 28 Aug 2007 15:26:48 -0500 [thread overview]
Message-ID: <46D48508.9060001@sandeen.net> (raw)
In-Reply-To: <20070828200416.GG61154114@sgi.com>
David Chinner wrote:
> On Sun, Aug 26, 2007 at 01:35:07AM -0500, Eric Sandeen wrote:
>> Simplify vnode tracing calls by embedding function name & return addr
>> in the calling macro.
>>
>> Also do a lot of vnode->inode renaming for consistency, while
>> we're at it.
>>
>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>
>> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_aops.c
>> ===================================================================
>> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_aops.c
>> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_aops.c
>> @@ -1525,8 +1525,7 @@ xfs_vm_bmap(
>> struct inode *inode = (struct inode *)mapping->host;
>> struct xfs_inode *ip = XFS_I(inode);
>>
>> - vn_trace_entry(XFS_I(inode), __FUNCTION__,
>> - (inst_t *)__return_address);
>> + ip_trace_entry(XFS_I(inode));
>
> s/ip_trace/xfs_itrace/
>
So xfs_itrace_entry, xfs_itrace_ref, xfs_itrace_exit etc is what you prefer?
-Eric
next prev parent reply other threads:[~2007-08-28 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-26 6:35 [PATCH] clean up vnode^winode tracing Eric Sandeen
2007-08-26 16:39 ` Christoph Hellwig
2007-08-28 20:04 ` David Chinner
2007-08-28 20:26 ` Eric Sandeen [this message]
2007-08-28 20:35 ` [PATCH V2] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D48508.9060001@sandeen.net \
--to=sandeen@sandeen.net \
--cc=dgc@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.